Labels Milestones

Completed basic design of navbar, sidebar, search tool, accordions, help and feedback #2

Merged

dtookey merged 24 commits from RebeccaBranch into master 5 years ago

Conversation 1 Commits 24 Files Changed 26

bhollis commented 5 years ago

Collaborator

I've completed several goals for the basic design. This seems like a good point to send what I have in preparation for the next phase of work.

I've completed several goals for the basic design. This seems like a good point to send what I have in preparation for the next phase of work.

bhollis added 23 commits 5 years ago

06482010aa couldn't change colors of footer text or accordion buttons

94b0bca777 Merge remote-tracking branch 'origin/master' into RebeccaBranch

cabff002b4 added help dropdown and feedback dropdown

5e86195d24 changing help and feedback dropdown placement, size, color

a372fedbb2 wrote the help windows

90be028c39 cleaned up some resource-landing

938137ae7f Merge remote-tracking branch 'origin/RebeccaBranch' into RebeccaBranch

613268a4e1 implemented first help overlay

4dbed3b19f implemented import of content into help overlay

fbb8d174f1 implemented style of help screen content div

3ceb4ff8f0 cleaned up help-about.html

32e93e6b93 changed color of chevrons to fit theme

2f5997f992 Modified help dropdown text color

5cbe73c31e changed foother text color with a class

6367be66b4 Made sidebar textcolor more dynamic

9db51f3c0d Made sidebar textcolor more dynamic

833664bb1b window is limited to minimum of 769. this prevents media resizing

37e8d5b13f updated help window html and assigned themed colors for chevrons

44b9b6f7df improved sidebar hover bg and text colors, fixed wrapping of nav bar when screen width smaller, tweaked active/inactive accordion and chevron colors

0e742c0aba made a footer hover and click color change

d5e95db8f3 made search button change colors on click

d3f9146a92 made the nav items change color on hover

7588f397d6 designed the help screens and tried to change theme toggle colors

bhollis added 1 commit 5 years ago

e907591269 made the webcards the same height with buttons lined up along bottom, no matter the screen width

dtookey commented 5 years ago

Owner

I'm going to approve this, but I have comments about a few things.

• Are we sure we want a feedback button?
• In src/assets/pages/styles/resources-landing-page.scss, are you sure that you want inline svgs instead of keeping them in their own file and referencing them with an <img> element? (line 133)

I'm going to approve this, but I have comments about a few things. * Are we sure we want a feedback button? * In src/assets/pages/styles/resources-landing-page.scss, are you sure that you want inline svgs instead of keeping them in their own file and referencing them with an `<img>` element? (line 133)

dtookey approved these changes 5 years ago

dtookey closed this pull request 5 years ago

dtookey reopened this pull request 5 years ago

dtookey approved these changes 5 years ago

dtookey left a comment

Owner

Huh, it didn't merge on the first approval

Huh, it didn't merge on the first approval

dtookey changed title from WIP: Completed basic design of navbar, sidebar, search tool, accordions, help and feedback to Completed basic design of navbar, sidebar, search tool, accordions, help and feedback 5 years ago

dtookey merged commit dd4c349321 into master 5 years ago

dtookey referenced this issue from a commit 5 years ago

Merge pull request 'Completed basic design of navbar, sidebar, search tool, accordions, help and feedback' (#2) from RebeccaBranch into master

Reviewers

dtookey approved these changes 5 years ago

The pull request has been merged as dd4c349321.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b RebeccaBranch master

git pull origin RebeccaBranch

Step 2:

Merge the changes and update on Gitea.

git checkout master

git merge --no-ff RebeccaBranch

git push origin master

Sign in to join this conversation.

Reviewers

Request review

No reviewers

dtookey

Labels

Apply labels

Clear labels

No items

No Label

Milestone

Set milestone

Clear milestone

No items

No Milestone

Projects

Set Project

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: dtookey/Engine_Rebuild#2

Write Preview

Loading…

Cancel

Save

There is no content yet.